Change review_state in extensions.xml to prevent wrong results in EM

extensions/ter_fe2/Classes/Service/ExtensionIndexService.php

@@ -135,7 +135,9 @@ class ExtensionIndexService implements LoggerAwareInterface
                 $versionObj->appendChild(new \DOMElement('title', $this->xmlentities((string)$extensionVersionArr['title'])));
                 $versionObj->appendChild(new \DOMElement('description', $this->xmlentities((string)$extensionVersionArr['description'])));
                 $versionObj->appendChild(new \DOMElement('state', $this->xmlentities((string)$extensionVersionArr['state'])));
-                $versionObj->appendChild(new \DOMElement('reviewstate', (string)$extensionVersionArr['review_state']));
+                // Use "0" for outdated extension versions as the Extension Manager handles it as insecure
+                $reviewState = (string)((int)$extensionVersionArr['review_state'] !== -2 ?: 0);
+                $versionObj->appendChild(new \DOMElement('reviewstate', $reviewState));
                 $versionObj->appendChild(new \DOMElement('category', $this->xmlentities((string)$extensionVersionArr['em_category'])));
                 if ($extensionVersionArr['category'] === 'distribution') {
                     $prefixDistributionFilePath = $extensionKey[0] . '/' . $extensionKey[1] . '/' . $extensionKey . '_' . $versionNumber . '_';