[TASK] Improve logging of hooks

* log hook name and arguments once per hook
* add newline after each hook file execution
* fix shellcheck issues
* remove extra logging in update-forge-issue hook

assets/hooks/change-merged

 #!/bin/bash
 
 HOOK=$0
-HOOK_NAME=$(basename $0)
+HOOK_NAME=$(basename "$0")
 
-for file in $HOOK.d/*; do
-  if [[ -x "$file" ]]; then
-    echo "Executing hook $HOOK_NAME file $file" >> /var/gerrit/logs/change-merged.log
-    $file --action $HOOK "$@" >> /var/gerrit/logs/change-merged.log
-  fi
-done
+{
+  echo "Executing ${HOOK_NAME} with arguments $*"
+  for file in "${HOOK}".d/*; do
+    if [[ -x "$file" ]]; then
+      echo "Executing $file:"
+      $file --action "${HOOK}" "$@"
+      echo ""
+    fi
+  done
+} >>/var/gerrit/logs/change_merged_log

assets/hooks/patchset-created

 #!/bin/bash
 
 HOOK=$0
-HOOK_NAME=$(basename $0)
+HOOK_NAME=$(basename "$0")
 
-for file in $HOOK.d/*; do
-  if [[ -x "$file" ]]; then
-    echo "Executing hook $HOOK_NAME file $file" >> /var/gerrit/logs/patchset-created.log
-    $file --action $HOOK "$@" >> /var/gerrit/logs/patchset-created.log
-  fi
-done
+{
+  echo "Executing ${HOOK_NAME} with arguments $*"
+  for file in "${HOOK}".d/*; do
+    if [[ -x "$file" ]]; then
+      echo "Executing $file:"
+      $file --action "${HOOK}" "$@"
+      echo ""
+    fi
+  done
+} >>/var/gerrit/logs/patchset_created_log

assets/hooks/patchset-created.d/update-forge-issue.phpsh

@@ -6,15 +6,6 @@ require_once dirname(__FILE__) . '/../get-commit-message.php';
 
 $args = getArguments();
 
-// log input parameters
-$parametersGiven = [];
-foreach ($args as $key => $value) {
-    $parametersGiven[] = $key . ':' . $value;
-}
-echo 'Executing hook file ' . __FILE__ . ' (' . implode(', ', $parametersGiven) . ')';
-unset($parametersGiven);
-
-
 // fetch commit message
 $commitInfo = getCommitMessage($args['project'], $args['commit']);